topic Re: The access violation when create material attribute in Archicad C++ API

The access violation when create material attribute

Anonymous — Thu, 29 Sep 2022 07:54:21 GMT

Hi.
The access violation error occuers when I create a material attribute.
my code is


API_AttrTypeID typeID = API_MaterialID;
API_Attribute		attrib;
	API_AttributeDefExt	defs;
	BNZeroMemory(&attrib, sizeof(API_Attribute));
attrib.header.typeID = typeID;
	strcpy(attrib.header.name, u8"玻璃 - 蓝色");
	err = ACAPI_Attribute_Get(&attrib);
	if (err == NoError) {
		err = ACAPI_Attribute_GetDefExt(typeID, attrib.header.index, &defs);
		if (err == APIERR_BADID) {
			BNZeroMemory(&defs, sizeof(API_AttributeDefExt));
			err = NoError;
		}
		//能见度100
		attrib.material.transpPc = 100;
		if (err == NoError) {
			strcpy(attrib.header.name, name.ToCStr().Get());
			err = ACAPI_Attribute_Create(&attrib,nullptr);
		}
		ACAPI_DisposeAttrDefsHdlsExt(&defs);
	}

Re: The access violation when create material attribute

Akos Somorjai — Tue, 03 Dec 2019 13:43:12 GMT

Hi,

Please use attrib.header.uniStringNamePtr Instead of attrib.header.name, because the .name is limited in length:

GS::UniString attrName (u8"玻璃 - 蓝色");
attrib.header.uniStringNamePtr = &attrName;

and instead of strcpy(attrib.header.name, name.ToCStr().Get()); use:

attrib.header.uniStringNamePtr = &name;

Best, Akos

Re: The access violation when create material attribute

Anonymous — Wed, 04 Dec 2019 01:08:35 GMT

Akos wrote:
Hi,

Please use attrib.header.uniStringNamePtr Instead of attrib.header.name, because the .name is limited in length:
GS::UniString attrName (u8"玻璃 - 蓝色");
attrib.header.uniStringNamePtr = &attrName;
and instead of strcpy(attrib.header.name, name.ToCStr().Get()); use:
attrib.header.uniStringNamePtr = &name;
Best, Akos

According to your method,the problem also occuers.

Re: The access violation when create material attribute

Ralph Wessel — Wed, 04 Dec 2019 09:41:49 GMT

DevJeer wrote:
Akos wrote:
Hi,

Please use attrib.header.uniStringNamePtr Instead of attrib.header.name, because the .name is limited in length:
GS::UniString attrName (u8"玻璃 - 蓝色");
attrib.header.uniStringNamePtr = &attrName;
and instead of strcpy(attrib.header.name, name.ToCStr().Get()); use:
attrib.header.uniStringNamePtr = &name;
Best, Akos
According to your method,the problem also occuers.

I notice you've changed the call for creating the material to ACAPI_Attribute_CreateExt and you're passing a API_AttributeDefExt parameter. Materials don't use API_AttributeDefExt, so perhaps you should be passing just nullptr for that parameter?

Re: The access violation when create material attribute

Akos Somorjai — Wed, 04 Dec 2019 16:57:34 GMT

Hi,

Here's the code that works for me:

{
	GS::UniString name (u8"能见度100");

	API_AttrTypeID typeID = API_MaterialID;
	API_Attribute attrib = {};
	API_AttributeDefExt defs = {};
	GSErrCode err = NoError;

	GS::UniString attrName(u8"玻璃 - 蓝色");
	attrib.header.typeID = typeID;
	attrib.header.uniStringNamePtr = &attrName;
	//strcpy(attrib.header.name, u8"玻璃 - 蓝色");
	err = ACAPI_Attribute_Get (&attrib);
	if (err == NoError)
	{
		err = ACAPI_Attribute_GetDefExt (typeID, attrib.header.index, &defs);
		if (err == APIERR_BADID)
		{
			err = NoError;
		}
		//能见度100
		attrib.material.transpPc = 100;
		if (err == NoError)
		{
			attrib.header.uniStringNamePtr = &name;
			//strcpy(attrib.header.name, name.ToCStr().Get());
			err = ACAPI_Attribute_CreateExt (&attrib, &defs);
		}
	}
	ACAPI_DisposeAttrDefsHdlsExt(&defs);

	return;
}

I think the main problem was calling ACAPI_Attribute_Create instead of ACAPI_Attribute_CreateExt.

Best, Akos

Re: The access violation when create material attribute

Anonymous — Thu, 05 Dec 2019 01:20:32 GMT

Thanks.
The code don't work for me.


API_AttrTypeID typeID = API_MaterialID;
GSErrCode err = NoError;
API_Attribute attrib={};
API_AttributeDefExt defs={};

attrib.header.typeID = typeID;
//strcpy(attrib.header.name, u8"玻璃 - 蓝色");
GS::UniString materialName(u8"玻璃 - 蓝色");
attrib.header.uniStringNamePtr = &materialName;
err = ACAPI_Attribute_Get(&attrib);
if (err == NoError) {
    err = ACAPI_Attribute_GetDefExt(typeID, attrib.header.index, &defs);
    if (err == APIERR_BADID) {
        BNZeroMemory( & defs, sizeof(API_AttributeDefExt));
        err = NoError;
    }
    //能见度100
    attrib.material.transpPc = 100;
    if (err == NoError) {
        //strcpy(attrib.header.name, name.ToCStr().Get());
        GS::UniString attrName(u8"界线");
        attrib.header.uniStringNamePtr = &attrName;
        err = ACAPI_Attribute_CreateExt( &attrib, &defs);
    }
    ACAPI_DisposeAttrDefsHdlsExt(&defs);
}

The same problem also occurs.
The version of Archicad is 22 and the version of vs is 2015.