topic Re: Cannot compile AC26 addon for AC27 in Archicad C++ API

Cannot compile AC26 addon for AC27

YourQS — Tue, 17 Sep 2024 11:07:48 GMT

I have a plugin that compiles and works fine in AC26. I am upgrading it to AC27. I have installed the AC27 API kit and changed all references in the project file to the 27.3001 folder.

I now get about 6000 errors, many of them like these:

Code:

CParameter* Factory(const API_AddParType &parameter);

Errors:

Error C4430 missing type specifier - int assumed. Note: C++ does not support default-int Error C2143 syntax error: missing ',' before '&'

The Visual Studio IDE is able to identify the type API_AddParType and can navigate to the .h file if I press F12 on the type, but the compiler doesn't seem to be able to find it. (See attached image)

Could someone help with what I need to change to resolve this issue?

Re: Cannot compile AC26 addon for AC27

BerndSchwarzenbacher — Tue, 12 Dec 2023 10:16:52 GMT

Did you specify C++17 for your Project when compiling for AC27? The AC27 DevKit assumes the use of C++17.

Re: Cannot compile AC26 addon for AC27

YourQS — Tue, 12 Dec 2023 18:20:05 GMT

Hi Bernd, yes I had already set C++17 as the language standard, thanks, but that did not resolve these issues.

Re: Cannot compile AC26 addon for AC27

BerndSchwarzenbacher — Tue, 12 Dec 2023 20:21:02 GMT

Hm.. I took a closer look. API_AddParType is defined for the AC27 DevKit. But CParameter is not.

In fact, when I copy your code line into one of my projects, I get the exact same errors and Visual Studio highlights CParameter as missing. So I think it's very likely that somehow you are not properly including the headers which define CParameter. Where do you get this type from?

Best,
Bernd

Re: Cannot compile AC26 addon for AC27

YourQS — Sun, 17 Dec 2023 21:56:08 GMT

Hi Bernd,

It is one of our own classes defined in Parameter.hpp, which is included in the file. here is a large snippet showing the original code and the include. What is peculiar is that the VS IDE happily identifies CParameter, (no red squiggle) and I can navigate to it by pressing F12 on it in the IDE

Regards,

Nick

#ifndef _PARAMETERCOLLECTION_HPP_ #define _PARAMETERCOLLECTION_HPP_ #include "Definitions.hpp" #include <vector> #include "WString.hpp" #include <Parameter.hpp> using namespace std; class CParameterCollection { protected: vector<CParameter*> m_collection; protected: void ClearCollection(); void CopyCollection(const CParameterCollection &src); CParameter* Factory(const API_AddParType &parameter);

Re: Cannot compile AC26 addon for AC27

BerndSchwarzenbacher — Thu, 14 Dec 2023 08:07:28 GMT

Hi Nick,

It's a tough one. I don't see anything obviously wrong with the code.

A few questions:

Where is the file Parameter.hpp located? I'm wondering why you are including it with angle brackets instead of quotes.
Can you show the definition of CParameter? (Please use the function "Insert/Edit code sample" on here for better formatting of code)
Can you prepare a minimal example project without proprietary code where the compilation still fails? Ideally just CParameter definition + a file where it's included + the project definition. This might be a lot of work, but might help you debugging the issue and if you have a small example, you might be able to share it with us for us to investigate.

Best,
Bernd

Re: Cannot compile AC26 addon for AC27

Mihaly Palenik — Fri, 21 Jun 2024 04:59:54 GMT

Hello,

at first as Bernd pointed out is there any reason you use angle brackets instead of quotes? Please try to modify to

#include "Parameter.hpp"

It is unclear to me whether this error you mentioned refers to CParameter or API_AddParType. Moreover API_AddParType is in APIdefs_LibraryParts.h but I cannot see where it is included. Please try to include it.

Re: Cannot compile AC26 addon for AC27

YourQS — Sun, 23 Jun 2024 19:50:38 GMT

Hi Mihaly,

Thanks for taking a look at the problem we are having.

I did try changing the angle brackets to quotes when Berndt first suggested it, but the errors remained. I think it is worth reiterating that the code (with the angle brackets) compiles fine when the references are to the AC26 API. It only fails when the AC27 API is referenced.

I have tried including a reference to APIdefs_LibraryParts.h, but that also did not help.

Regards,

Nick

Re: Cannot compile AC26 addon for AC27

Akos Somorjai — Tue, 25 Jun 2024 13:33:10 GMT

Hi,

Have you tried to predeclare API_AddParType before its first use?

struct API_AddParType;

Best, Akos

Re: Cannot compile AC26 addon for AC27

YourQS — Wed, 26 Jun 2024 19:45:53 GMT

Hi Akos,

I added that line before the first reference to API_AddParType, but the error output remained exactly the same.

Regards,

Nick

Re: Cannot compile AC26 addon for AC27

Mihaly Palenik — Thu, 27 Jun 2024 05:44:46 GMT

Hello,

where do you put it exactly? Right before the first reference like this:

#ifndef _PARAMETERCOLLECTION_HPP_ #define _PARAMETERCOLLECTION_HPP_ #include "Definitions.hpp" #include <vector> #include "WString.hpp" #include <Parameter.hpp> using namespace std; class CParameterCollection { protected: vector<CParameter*> m_collection; protected: void ClearCollection(); void CopyCollection(const CParameterCollection &src); // added line struct API_AddParType; CParameter* Factory(const API_AddParType &parameter);

or before the class like this?

#ifndef _PARAMETERCOLLECTION_HPP_ #define _PARAMETERCOLLECTION_HPP_ #include "Definitions.hpp" #include <vector> #include "WString.hpp" #include <Parameter.hpp> using namespace std; // added line struct API_AddParType; class CParameterCollection { protected: vector<CParameter*> m_collection; protected: void ClearCollection(); void CopyCollection(const CParameterCollection &src); CParameter* Factory(const API_AddParType &parameter);

Re: Cannot compile AC26 addon for AC27

Akos Somorjai — Thu, 27 Jun 2024 09:05:24 GMT

Hi,

Another idea:

#include <vector> #ifndef ACExtension #define ACExtension #endif #include "APIdefs_LibraryParts.h" #include "WString.hpp"

Best, Akos

Re: Cannot compile AC26 addon for AC27

YourQS — Tue, 02 Jul 2024 20:33:05 GMT

Hi Mihaley,

I had put it before the class. When I put it directly before the reference, it gets rid of one compiler error, but then throws this error:

Error C2027 use of undefined type 'CParameterCollection::API_AddParType'

Thanks and regards,

Nick

Re: Cannot compile AC26 addon for AC27

YourQS — Tue, 02 Jul 2024 19:58:46 GMT

Hi Akos,

Yes, that seems to get rid of about 20 of the remaining 2000 compiler errors.

Thanks and regards,

Nick

Re: Cannot compile AC26 addon for AC27

Viktor Kovacs — Tue, 02 Jul 2024 20:52:21 GMT

Another idea: it seems that the DevKit also has a file named "Parameter.hpp" (Support/Modules/GSModelDevLib/Parameter.hpp). I can imagine that somehow the AC27 build finds the one in the DevKit before the one in your library. Please try to rename your file to e.g. "CParameter.hpp" and check if that solves the problem.

If this doesn't help, please provide the full build log. When you have so many errors sometimes the real reason is hidden somewhere in the log.

Re: Cannot compile AC26 addon for AC27

YourQS — Tue, 02 Jul 2024 21:29:24 GMT

Hi Viktor,

I tried renaming Parameter.hpp, but it did not solve the problem. I have attached a file with the build log.

Thanks and regards,

Nick

Re: Cannot compile AC26 addon for AC27

Viktor Kovacs — Tue, 02 Jul 2024 22:10:21 GMT

Most of the errors seemingly are coming from changes in the API interface between AC26 and AC27. There are - at least - two parts of the story.

1. API_AttributeIndex

API_AttributeIndex has been changed from a number to a class.

// AC26 typedef Int32 GSIndex; typedef GSIndex API_AttributeIndex; // AC27 class API_AttributeIndex { // ... }

From the log it seems that you are using API_AttributeIndex as a number at several places, like in an std::map that requires a comparison operator that the new class doesn't have.

std::map<API_AttributeIndex, int> m;

Probably it will mean a bigger rewrite for you to use the class everywhere. For now you can get the index from the class, but I highly recommend using the class for future compatibility.

2. Function renames

Several functions has been renamed in AC27. For example ACAPI_LibPart_Get is called ACAPI_LibraryPart_Get in AC27.

What can you do?

You have two options:

You can separate the code for AC26 and AC27 and do the update only in the AC27 codebase.
If you prefer to have one code base for both versions you can create a header that resolves these dependencies.

Example for such migration header:

#ifndef ServerMainVers_2700 #define ACAPI_LibraryPart_GetNum ACAPI_LibPart_GetNum #define ACAPI_LibraryPart_Search ACAPI_LibPart_Search #define ACAPI_LibraryPart_Create ACAPI_LibPart_Create // ... #endif

Since there were many changes between the two versions, prepare for a bigger task to rewrite everything. In case of renames it's "only" a manual task, in case of attribute index handling you need to figure out what will work the best for you.

Re: Cannot compile AC26 addon for AC27

YourQS — Wed, 03 Jul 2024 19:36:10 GMT

Hi Viktor,

Thanks for that. Is there a list of function name changes? I have looked at https://graphisoft.github.io/archicad-api-devkit/md__common_doxygen_files_2_articles_2_new_01_a_p_i_01features_01in_01_archicad.html but it just says that many names have changed.

Regards,

Nick

Re: Cannot compile AC26 addon for AC27

BerndSchwarzenbacher — Wed, 03 Jul 2024 19:44:07 GMT

Hi Nick,

You can check the file Support/Inc/ACAPI_MigrationHeader.hpp in the AC27 SDK for a list of (I think) all function name changes.
Unfortunately I wasn't able to use the file directly without modifications.
I think I've used following modifications to use it:

Make all functions inline
Document out functions where the conversion doesn't work for some reason or fix it if I need exactly one of these.

Hope that helps!

Re: Cannot compile AC26 addon for AC27

YourQS — Mon, 08 Jul 2024 22:37:58 GMT

Hi Bernd, Akos, and Viktor,

I have made the changes suggested by Akos for the renamed functions and new class. I am still getting the original many errors where the compiler cannot find definitions , when the IDE can.

Bernd, I have taken your original suggestion of creating a small project that demonstrates the problem; the whole plugin is quite small, so I have attached it. Please could you try opening and compiling it?

Thanks and regards,

Nick