topic Re: Why does parameter update works differently for doors in 25+ in GDL

Why does parameter update works differently for doors in 25+

Barry Kelly — Mon, 22 Jul 2024 06:06:47 GMT

I hope I can explain this clearly.

Sample version 22 objects are attached.

I have a door object that works perfectly fine in version 22.

It has a parameter list of widths (parameter A) and a matching parameter list of door leaf sizes sizes and a parameter for the number of door.

I have used GLOB_MODPAR_NAME to say when the number of door leaf is changed, the overall width (A) should change as well - simply the number of door x the door leaf width.

I have simplified the code to what is in the attached objects (parameter script).

values "size" 0.72,0.82!,custom values "a" 0.72*numdoor, 0.82*numdoor!, !!!!! if I un-comment these two lines !custom !!!!! then it will work correctly if GLOB_MODPAR_NAME = "numdoor" then a=size*numdoor PARAMETERS a=a endif

So it is very straight forward.

If I change the parameter for the number of doors, the value of A should change.

Which it does perfectly in version 22.

Now exactly the same objects used in version 25 - the door does not work properly.

Change the number of doors in the parameter to 2, the object settings show the correct value in the object settings, press OK, the info box briefly shows the correct value and then it changes to the firs value in the value list for A.

It should not do this.

i.e A =820, number of doors = 1 and door leaf width (size) = 820.

Change the number of doors to 2, then A should become 1640.

Instead it becomes 1440, which is 2 times first value in size list.

Oddly if I create an object with exactly the same code, it works in both 22 and 25.

Object and door object are attached - pleas try for yourself.

If I add a 'custom' size to the parameter list for A, then is also works, but the problem is I would rather not allow a custom size for A.

I want a fixed list of sizes.

This is what I see in 22.

But in version 25+ it does not work.

Does anyone know of a reason why it does not work?

@Peter Baksa if you have time to look at this it would be appreciated.

Attached is a short video as well.

22 is on the left, 25 is on the right.

Pause at 19 seconds and you will see info box shows 1640 for width (A) then changes to 1440.

Barry.

Re: Why does parameter update works differently for doors in 25+

BrunoH — Mon, 22 Jul 2024 06:37:02 GMT

Hi Barry Kelly,

maybe because the value custom is a comment on the first line ?

Re: Why does parameter update works differently for doors in 25+

Barry Kelly — Mon, 22 Jul 2024 07:08:49 GMT

No that is not it.

I just scripted that out to see if it did make a difference and it doesn't.

Thanks,

Barry,

Re: Why does parameter update works differently for doors in 25+

MF BIM — Mon, 22 Jul 2024 07:53:25 GMT

Does the bug still happens if you run the Parameter script once ?

Re: Why does parameter update works differently for doors in 25+

BrunoH — Mon, 22 Jul 2024 07:59:10 GMT

Hi,

I think your script can't work properly even if you un-comment the two lines because you calculate the "a" value only if the "numdoor" value change but you can change the "size" value and then need to re-calculate the "a" one.

I think you just have to calculate the "a" value each time so just delete the "if GLOB_MODPAR_NAME = "numdoor" then" and the "endif" lines.

Or if you want different actions regarding the modified parameter you'll have to set a "if GLOB_MODPAR_NAME" sequence for each one.

Re: Why does parameter update works differently for doors in 25+

Barry Kelly — Mon, 22 Jul 2024 08:11:42 GMT

I have tried but I will check again.

I have tried checking if it the 'isfirstrun' for the entire script as well as just parts (just the GLOB_MODPAR_NAME) but no luck.

I even tried the option in the compatibility option to run parameter script once.

No luck.

The question is why does it work correctly as an object but not as a door (exactly the same sctipt)

Barry.

Re: Why does parameter update works differently for doors in 25+

Barry Kelly — Mon, 22 Jul 2024 08:15:17 GMT

The thing is the script works fine in version 22 but not in 25.

I am not sure at what version it changed as I skipped from 22 to 25.

I will have to do some investigating on that.

And odd that the exactly the same script works if saved as an object, but not when saved as a door.

Barry.

Re: Why does parameter update works differently for doors in 25+

Barry Kelly — Mon, 22 Jul 2024 08:58:05 GMT

It has something to do with the parameter list for A being size x numbdoor.

If I set the parameter list to fixed values ... VALUES "A" 0.72, 0.82, 1.44, 1.64

Then it works OK.

But again why is being saved as a door object different to being saved as a regular object?

The problem now is my object may have 1 door leaf, 2, 3 or 4 door leaves - even more possibly.

And to complicate it even more the A parameter list also needs to allow for an adjustable frame to door leaf clear and, a double door leaf clearance and even extra intermediate frames for when there are more than to doors.

So my real door object A parameter list is more like...

values "a" (0.41*numdoor)+(2*frame+2*clearance)+(2*wall_type)+(intframe*(int_frame_wid+2*clearance))+INT(numdoor/2)*dble_leaf_cent_clear,
(0.52*numdoor)+(2*frame+2*2*clearance)+(2*wall_type)+(intframe*(int_frame_wid+2*clearance))+INT(numdoor/2)*dble_leaf_cent_clear,
(0.62*numdoor)+(2*frame+2*clearance)+(2*wall_type)+(intframe*(int_frame_wid+2*clearance))+INT(numdoor/2)*dble_leaf_cent_clear,
(0.72*numdoor)+(2*frame+2*clearance)+(2*wall_type)+(intframe*(int_frame_wid+2*clearance))+INT(numdoor/2)*dble_leaf_cent_clear,
(0.82*numdoor)+(2*frame+2*clearance)+(2*wall_type)+(intframe*(int_frame_wid+2*clearance))+INT(numdoor/2)*dble_leaf_cent_clear,
(0.87*numdoor)+(2*frame+2*clearance)+(2*wall_type)+(intframe*(int_frame_wid+2*clearance))+INT(numdoor/2)*dble_leaf_cent_clear,
(0.92*numdoor)+(2*frame+2*clearance)+(2*wall_type)+(intframe*(int_frame_wid+2*clearance))+INT(numdoor/2)*dble_leaf_cent_clear,
custom

It is weird how adding 'custom' to the end of the list works.

It seems to use the custom size at first because it is not in the original list of A sizes.

Then it sees that the size is in the new list of values for A and then uses the correct size from the list.

But again it is odd why the door object works differently to an actual object.

Maybe I need to look at how the parameter list for A is generated.

Barry.

Re: Why does parameter update works differently for doors in 25+

SenecaDesignLLC — Mon, 22 Jul 2024 13:06:29 GMT

Try moving the parameters a =a out of the if statement.

And maybe set it to itself first.

If----

Endif

a=a

Parameters a=a

Re: Why does parameter update works differently for doors in 25+

Barry Kelly — Tue, 23 Jul 2024 02:46:13 GMT

@SenecaDesignLLC wrote:

Try moving the parameters a =a out of the if statement.

If I take it out of the if GLOB_MODPAR_NAME statement, it does work.

But it does need to be ...

a=size*numdoor
PARAMETERS a=a

I am not sure why taking it out of the if statement works, but I will give it a try in my real door object.

Still, why is the way the script work in the door object different to the way it works in a normal object?

That is still a puzzle for me.

Thanks,

Barry.

Re: Why does parameter update works differently for doors in 25+

Peter Baksa — Wed, 31 Jul 2024 10:01:57 GMT

Hi Barry,

This is a bug, I will report it. A workaround may be that you round the custom value to the closest allowed one. And it is possible to show only certain values of a parameter with ui_infield{3}.

Re: Why does parameter update works differently for doors in 25+

Barry Kelly — Thu, 01 Aug 2024 02:32:08 GMT

@Peter Baksa wrote:

This is a bug, I will report it.

Thanks Peter.

I thought it was odd that it works for an object but not a door (and it used to work before).

I seem to have solved it by taking the updating of 'A' parameter out of the IF_GLOBMODPAR_NAME routine, and then adding the VALUES list for 'A' after this.

There is probably something wrong with that method, but it seems to be working (fingers crossed).

Barry.

Re: Why does parameter update works differently for doors in 25+

mthd — Thu, 01 Aug 2024 03:42:44 GMT

Does it really need to be so complicated in a workflow using standard door sizes to go to simple double doors ? How much time did it take to edit the script and make this post ? I would have a builder chasing my tail if I take too long in doing a simple task like this. I can’t afford to fudge around with scripts that waste valuable time just like @Barry Kelly has done here.

Why not just a have a change to double door tab in the dialogue box ? Then you don’t have to check every new version to see if it still works.

I guess coming from an estimating background with builders on your back makes me think like this. I should have become an Architect so I have plenty of time to fiddle with the app.

Re: Why does parameter update works differently for doors in 25+

Barry Kelly — Thu, 01 Aug 2024 04:06:18 GMT

@mthd wrote:

Does it really need to be so complicated in a workflow using standard door sizes to go to simple double doors ? How much time did it take to edit the script and make this post ? I would have a builder chasing my tail if I take too long in doing a simple task like this. I can’t afford to fudge around with scripts that waste valuable time just like @Barry Kelly has done here.

Why not just a have a change to double door tab in the dialogue box ? Then you don’t have to check every new version to see if it still works.

Everything still needs to be scripted in the objects.

This problem is also peculiar to the way I have scripted my own door object.

I am sure in the default Graphisoft objects it is handled differently and won;t be a problem (I don't use the Graphisoft doors and windows).

I think the Graphisoft objects may even have separate objects for single and double doors.

Mine is all in one, even does 3 or 4 door frames for built in robes.

I spend the time trying to get my objects working as efficiently as I can because I have 40 other people in the office that use them.

I am in the fortunate position that it is my job to makes other peoples' jobs as easy as possible.

A smaller office or single operator may not have the luxury to be able to mess around scripting objects.

Barry.

Re: Why does parameter update works differently for doors in 25+

mthd — Thu, 01 Aug 2024 05:02:32 GMT

Yes and using multiple doors for robes is also common in my area too.

I see that having a good office template makes sense in your particular workflow scenario. Having a knowledge of scripting is quite helpful for programming common default elements like doors, windows etc.

Cheers !

Re: Why does parameter update works differently for doors in 25+

Late — Wed, 02 Oct 2024 10:12:31 GMT

Hi @Peter Baksa

Attached Window update problem has similar behavior with valuelists and might be relative to this bug, isn't it. Please find explanation picture below to help you find a solution to the problem. Or let us know if workaround exist...

Best regs!

Re: Why does parameter update works differently for doors in 25+

Peter Baksa — Wed, 02 Oct 2024 12:15:25 GMT

Hi Late,

Custom values an be mixed with pre-defined ones:

values "a" 1.1, 1.5, range [1, 3], custom

Re: Why does parameter update works differently for doors in 25+

Late — Wed, 09 Oct 2024 16:11:49 GMT

Yes I know but it's not the issue here and doesn't solve it either.

Purpose is separate clear pre-set values (eg catalogue) and free input each other for user. Both cases need to control parameter A to stretching window right on 2D/3D (otherwise you can use two different parameters).

It's strange and very harmful that everything works fine in preview (see bug description #3) but not after clicking OK (#4) and you need to re-do it (#5-6).

regs