topic Re: DNC's bendy bar tool from 7 to 8.1 in Libraries & objects

DNC's bendy bar tool from 7 to 8.1

Ignacio Azpiazu — Fri, 23 Apr 2004 08:10:05 GMT

I used David's bendybartool (which comes with many other great objects in his GDL Cookbook) in a project I started in 7 and am now completing on 8.1.

I used it to make rain pipes which looked very rain-pipe-like on 7 and now on 8.1 shows what look like one of the end cylinder faces. The 2D looks as it always did.

Is there anything in bendybar's code that should get modified when migrating to 8? I am very tight on a deadline and that's why I am asking this here and not privately to David (who has always been great with support, by the way).

[bendybartool makes a bent-pipe type thing by alternating CYLINDs and ELBOWs with custom lengths, bend, twist, and curvature radius set by custom array parameters.]

Re: DNC's bendy bar tool from 7 to 8.1

Jochen Suehlo — Fri, 23 Apr 2004 14:11:00 GMT

This is a very strange behavior. I tested the object in AC8.1 and find the same as you.
When I change the array parameters name in the parameter field and in the script, it works better, but not well.
It must have to do with the arrays; they are declared 2 times: first in the parameter field, second in the master script, which is not necessary.
But if you delete the master script definition it will not work better.

You should test to write the object complete new in AC8.1 and leave out every part of the script that is not necessary, maybe this helps.

Re: DNC's bendy bar tool from 7 to 8.1

Jochen Suehlo — Fri, 23 Apr 2004 15:05:18 GMT

Okay, shooten too fast.

It was definetely the second defining of the Arrays in the master script that caused the strange behavior.

This script should work (in the master):

n=SPLIT(shape,"%n",shp)

brad=diam/2000 !Bar radius
FOR k=1 TO shp-1
IF crad<brad THEN crad=brad
IF bend<0 THEN
twist=twist+180
bend=ABS(bend)
ENDIF
IF leng<0 THEN leng=0
NEXT k
IF leng[shp]<0 THEN leng[6]=0

Re: DNC's bendy bar tool from 7 to 8.1

Anonymous — Fri, 23 Apr 2004 22:08:09 GMT

Ignacio and Joachim,
Do you have the revised version of this library part?
I notice that my copy has the statement somthing like
"April, revised 00".

I copied Joachim's code into DNC's master script
to compare them and Joachim's code is identical to DNC's code.
I did notice that in the master script DNC had comented out
the declaration of the three arrays with a comment that
in AC 8 you can't declare an array in the master script if it is already declared in the parameter list.
I also noticed that DNC comented out the statement,
brad=diam/2000 and substituted brad=diam/2.
Peter Devlin

Re: DNC's bendy bar tool from 7 to 8.1

Ignacio Azpiazu — Sat, 24 Apr 2004 09:53:13 GMT

Hi David, Joachim.

I think we are talking of the same version of bendibartool.
[!Bendibar
!Reinforcing bars
!David Nicholsoncole
!April 99
!Modified Jan 00]
And yes, David, my Master Script looks exactly like what Joachim pasted. Mine does not show the brad=diam/2000 to brad=diam/2 change you mention, so obviously there is at least one other difference somewhere else in the code.

I am new to 8 and have not checked the changes to GDL yet, and have not the slightest clue as to what may be producing the problem.

Re: DNC's bendy bar tool from 7 to 8.1

Ignacio Azpiazu — Sat, 24 Apr 2004 09:56:32 GMT

Ignacio wrote:
Hi David, Joachim.
(...)
And yes, David,

[Sorry about that. That should have been Hi, yes, *Peter*, Joachim.]

Re: DNC's bendy bar tool from 7 to 8.1

Anonymous — Sat, 24 Apr 2004 16:35:33 GMT

Ignacio,
Some time last year DNC posted on GDL TALK that in AC 8 you can't
declare an array in the master script if it is already declared in the
parameter list. I therefore changed the master scrpt for "Bendibar"
in the maner shown below and it works in AC 8.

Notice that the DIM statement is commented out.
Also notice that the brad=diam/2000 is commented out
and replaced with brad=diam/2. I changed this because I couldn't
figure out why it was defined that way.
You can leave this the way it is if you want but if you do change it
check the 3D script and make sure that it also says brad=diam/2.

!Bendibar
!Reinforcing bars
!David Nicholsoncole
!April 99
!Modified Jan 00

!!!DIM leng[7],crad[6],twist[6],bend[6]

!This is the long hard
!way to parse a value list
IF shape='1_Single Segment' THEN shp=1
IF shape='2_Two Segment' THEN shp=2
IF shape='3_Three Segment' THEN shp=3
IF shape='4_Four Segment' THEN shp=4
IF shape='5_Five Segment' THEN shp=5
IF shape='6_Six Segment' THEN shp=6
IF shape='7_Seven Segment' THEN shp=7

!If all you want is a flag
!then use SPLIT() instead
n=SPLIT(shape,"%n",shp)

100:!parameter checks
!!!!!brad=diam/2000 !Bar radius

brad=diam/2 !Bar radius

FOR k=1 TO shp-1
IF crad<brad THEN crad=brad
IF bend<0 THEN
twist=twist+180
bend=ABS(bend)
ENDIF
IF leng<0 THEN leng=0
NEXT k
IF leng[shp]<0 THEN leng[6]=0

Let us know if this fixes the problem,
Peter

Re: DNC's bendy bar tool from 7 to 8.1

Anonymous — Sat, 24 Apr 2004 16:37:23 GMT

Re: DNC's bendy bar tool from 7 to 8.1

Anonymous — Sat, 24 Apr 2004 16:38:22 GMT

Re: DNC's bendy bar tool from 7 to 8.1

Ignacio Azpiazu — Sat, 24 Apr 2004 18:27:23 GMT

Peter wrote:
Some time last year DNC posted on GDL TALK that in AC 8 you can't
declare an array in the master script if it is already declared in the
parameter list. I therefore changed the master scrpt for "Bendibar"
in the maner shown below and it works in AC 8.(...) Also notice that the brad=diam/2000 is commented out
and replaced with brad=diam/2. I changed this because I couldn't
figure out why it was defined that way.

Great, that did it and sort of saved my life at the last minute. Thank you so much.

Regarding the 2 vs 2000: I would guess you are using feet and inches for configuring the pipe diameter and therefore not needing to set the "Diam. of Bar in Millimetres" as originally intended. Internationally pipe diameters are given in mm and GDL will use m as its length unit, so that's why the /2 became /2000 in the script.

Re: DNC's bendy bar tool from 7 to 8.1

Anonymous — Sat, 24 Apr 2004 20:45:43 GMT

Ignacio,
Glad it worked.
You are right I am using feet and inches and I had forgotten
the "in Millimetres" in the parameter list. Now that you
have reminded me, what DNC did and what I did makes sense.
Thanks,
Peter

Re: DNC's bendy bar tool from 7 to 8.1

Anonymous — Sat, 24 Apr 2004 20:46:07 GMT

Re: DNC's bendy bar tool from 7 to 8.1

david nicholson-cole — Sun, 25 Apr 2004 10:14:28 GMT

Why didnt you write to me direct??, you must have my email i f you have the Cookbook CD.

The current Bendybar is fully 8.1 compatible with a user interface (and the 7.0 to 8.0 version bugs discussed above fully resolved)

Using the wonderful UI_INFIELD{2} command, you can now lay out all the data for the Bendybar in the User interface in a spreadsheet like display.

>>>davidnc

Ignacio wrote:
I used David's bendybartool (which comes with many other great objects in his GDL Cookbook) in a project I started in 7 and am now completing on 8.1.

I used it to make rain pipes which looked very rain-pipe-like on 7 and now on 8.1 shows what look like one of the end cylinder faces. The 2D looks as it always did.

Is there anything in bendybar's code that should get modified when migrating to 8? I am very tight on a deadline and that's why I am asking this here and not privately to David (who has always been great with support, by the way).

[bendybartool makes a bent-pipe type thing by alternating CYLINDs and ELBOWs with custom lengths, bend, twist, and curvature radius set by custom array parameters.]