Greetings, I'm having problems when using two Notification handlers. Basically it's a palette that uses SelectionChangeHandler to detect selected element (if wall is selected, it will show stuff) then ElemObserverHandler to detect changes from that element so the palette can update automatically. I attach elems to the observer in the SelectionChangeHandler function if it detects valid selection.
The crash happens when I do the following:
1) Open up the palette + Init handlers
2) Select an elem
3) Delete the selected elem
4) Select another elem
5) Undo-delete (Ctrl+Z). Archicad crashes immediately right after undo is pressed
Further testing:
1-3) Do actions
4) If I did not select an elem after deletion and went directly to undo-delete = no crash
Another scenario:
1-3) Do actions
4) If I multi-select elems after deletion then pressed undo = no crash
Another scenario:
1-4) Do actions
5) Un-select it, select another elem (repeated x times)
6) Undo-delete:
6a) If it has a selected elem = crash
6b) If it has no selected = no crash
Below is the code for the handlers, I've emptied the Elem Observer and palette (its created but no dialog items) so I know the SelectionChangeHandler has the problem.
API_Guid g_guidPrev = APINULLGuid;
bool g_hasSelected = false;
GSErrCode Observer_DetachAllElems()
{
API_Elem_Head** elemHead;
Int32 nElems = 0;
GSErrCode err = ACAPI_Element_GetObservedElements(&elemHead, &nElems);
if (err != NoError)
{
WriteReport("["__FUNC__"] ERROR %s - ACAPI_Element_GetObservedElements", ErrId2Name(err));
return err;
}
for (Int32 i = 0; i < nElems; i++)
{
err = ACAPI_Element_DetachObserver(&(*elemHead));
if (err != NoError) WriteReport("["__FUNC__"] ERROR %s - ACAPI_Element_DetachObserver()", ErrId2Name(err));
}
BMKillHandle((GSHandle*)&elemHead);
return err;
}
GSErrCode Observer_AttachElem(API_Guid guid)
{
// Get element head
API_Elem_Head head;
BNZeroMemory(&head, sizeof(head));
head.guid = guid;
GSErrCode err = ACAPI_Element_GetHeader(&head, APIElemMask_FloorPlan);
if (err != NoError)
{
WriteReport("["__FUNC__"] ERROR %s - ACAPI_Element_GetHeader()", ErrId2Name(err));
return err;
}
// Attach elem to observer
err = ACAPI_Element_AttachObserver(&head, NULL);
if (err != NoError)
WriteReport("["__FUNC__"] ERROR %s - ACAPI_Element_AttachObserver()", ErrId2Name(err));
return err;
}
static GSErrCode __ACENV_CALL ElemObserverEventHandler(const API_NotifyElementType* /*elemType*/)
{
// Empty function
return NoError;
} // ElemObserverEventHandler
GSErrCode InitializeElemObserverHandler()
{
const GSErrCode err = ACAPI_Notify_InstallElementObserver(ElemObserverEventHandler);
if (err != NoError) DBGPrintlnf("[Error] %s "__FUNC__" - ACAPI_Notify_InstallElementObserver(ElemObserverEventHandler)", ErrId2Name(err));
return err;
}
static GSErrCode __ACENV_CALL SelectionChangeHandler(const API_Neig *selElemNeig)
{
if (selElemNeig == nullptr)
return NoError;
if (selElemNeig->neigID == APINeig_None)
{
WriteReport("All elements deselected");
if (g_hasSelected) // Deselected (currently no selection & previously has selection)
{
g_hasSelected = false;
// Detach previous elem
Observer_DetachAllElems();
}
return NoError;
}
API_Neig** selNeigs;
API_SelectionInfo selectionInfo;
BNZeroMemory(&selectionInfo, sizeof(selectionInfo));
GSErrCode err = ACAPI_Selection_Get(&selectionInfo, &selNeigs, true);
BMKillHandle((GSHandle*)&selectionInfo.marquee.coords);
if (err == APIERR_NOSEL)
{
WriteReport("["__FUNC__"] ERROR %s - ACAPI_Selection_Get()", ErrId2Name(err));
err = NoError;
if (g_hasSelected) // Deselected (currently no selection & previously has selection)
{
g_hasSelected = false;
// Detach previous elem
Observer_DetachAllElems();
BMKillHandle((GSHandle*)&selNeigs);
return err;
}
}
if (err != NoError)
{
WriteReport("["__FUNC__"] ERROR %s - ACAPI_Selection_Get()", ErrId2Name(err));
BMKillHandle((GSHandle*)&selNeigs);
return err;
}
if (selectionInfo.typeID != API_SelEmpty)
{
// collect indexes of selected dimensiosn
const UInt32 nSel = BMGetHandleSize((GSHandle)selNeigs) / sizeof (API_Neig);
if (nSel != 1)
{ // exit since invalid selection, accept only single select
BMKillHandle((GSHandle*)&selNeigs);
return err;
}
// Valid selection: single select
API_Guid guid = (*selNeigs)[0].guid;
BMKillHandle((GSHandle*)&selNeigs);
if (g_guidPrev == guid) // Exit now if selected elem did not change
return NoError;
// Detach previous elem
Observer_DetachAllElems();
g_guidPrev = guid;
g_hasSelected = true;
// Check if elem is already being observed
API_Elem_Head** elemHead;
Int32 nElems = 0;
err = ACAPI_Element_GetObservedElements(&elemHead, &nElems);
if (err != NoError)
{
WriteReport("["__FUNC__"] ERROR %s - ACAPI_Element_GetObservedElements", ErrId2Name(err));
return err;
}
for (Int32 i = 0; i < nElems; i++)
{
if ((*elemHead).guid == guid) // Exit if already observed
{
BMKillHandle((GSHandle*)&elemHead);
return NoError;
}
}
BMKillHandle((GSHandle*)&elemHead);
// Attach elem to observer
Observer_AttachElem(guid);
}
return NoError;
} // SelectionChangeHandler
GSErrCode InitializeSelectionChangeHandler()
{
const GSErrCode err = ACAPI_Notify_CatchSelectionChange(SelectionChangeHandler);
if (err != NoError) DBGPrintlnf("[Error] %s "__FUNC__" - ACAPI_Notify_CatchSelectionChange(SelectionChangeHandler)", ErrId2Name(err));
return err;
}
